[Webkit-unassigned] [Bug 140116] [GStreamer][MSE] ASSERT in MediaSourceGStreamer::addSourceBuffer

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=140116

--- Comment #12 from Philippe Normand <pnormand at igalia.com> ---
(In reply to comment #11)
> Comment on attachment 244058 [details]
> patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=244058&action=review
> 
> > Source/WebCore/platform/graphics/gstreamer/SourceBufferPrivateGStreamer.cpp:68
> > +    SourceBufferPrivateClient::AppendResult result = m_mediaSource->client()->append(this, data, length);
> 
> Not in the scope of this bug, but MediaSourceClientGStreamer::append()
> doesn't have to operate on a PassRefPtr<SourceBufferPrivate> -- a simple
> reference to the SourceBufferPrivate object would do.
> 
> > Source/WebCore/platform/graphics/gstreamer/SourceBufferPrivateGStreamer.cpp:85
> > +    m_mediaSource->client()->removedFromMediaSource(this);
> 
> Same here, MediaSourceClientGStreamer::removedFromMediaSource() could
> operate with a reference to the SourceBufferPrivate object.

Right, I think I'll fix this in a separate patch. Thanks for pointing it out!

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20150108/370c3338/attachment-0002.html>