[Webkit-unassigned] [Bug 138991] Web Inspector: Pause Reason Improvements (Breakpoint, Debugger Statement, Pause on Next Statement)

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=138991

--- Comment #12 from Brian Burg <burg at cs.washington.edu> ---
Comment on attachment 244120
  --> https://bugs.webkit.org/attachment.cgi?id=244120
[PATCH] Proposed Fix

View in context: https://bugs.webkit.org/attachment.cgi?id=244120&action=review

>> Source/JavaScriptCore/inspector/agents/InspectorDebuggerAgent.cpp:143
>> +    RefPtr<Inspector::Protocol::Debugger::AssertPauseReason> reason = Inspector::Protocol::Debugger::AssertPauseReason::create();
> 
> auto might make this read better.

Please make the return type be 'RefPtr'. Using a local with type 'auto' will also make it possible to move RefPtr->Ref without changing the callsite.

(I wish we didn't store aux data as an untyped InspectorObject. But, there's no easy way to implement a disjoint union with inspector protocol types.)

> Source/JavaScriptCore/inspector/agents/InspectorDebuggerAgent.cpp:144
> +    if (!message.isNull())

Could message still be empty? I always get confused about .isNull() .isEmpty()

> Source/JavaScriptCore/inspector/agents/InspectorDebuggerAgent.cpp:589
> +    ASSERT(!injectedScript.hasNoValue());

ASSERT_ARG

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20150107/902bc46a/attachment-0002.html>