[Webkit-unassigned] [Bug 138991] Web Inspector: Pause Reason Improvements (Breakpoint, Debugger Statement, Pause on Next Statement)

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=138991

Timothy Hatcher <timothy at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #244120|review?                     |review+
              Flags|                            |

--- Comment #11 from Timothy Hatcher <timothy at apple.com> ---
Comment on attachment 244120
  --> https://bugs.webkit.org/attachment.cgi?id=244120
[PATCH] Proposed Fix

View in context: https://bugs.webkit.org/attachment.cgi?id=244120&action=review

> Source/JavaScriptCore/inspector/agents/InspectorDebuggerAgent.cpp:143
> +    RefPtr<Inspector::Protocol::Debugger::AssertPauseReason> reason = Inspector::Protocol::Debugger::AssertPauseReason::create();

auto might make this read better.

> Source/JavaScriptCore/inspector/agents/InspectorDebuggerAgent.cpp:152
> +    RefPtr<Inspector::Protocol::Debugger::CSPViolationPauseReason> reason = Inspector::Protocol::Debugger::CSPViolationPauseReason::create()
> +        .setDirective(directiveText);

Ditto.

> Source/JavaScriptCore/inspector/agents/InspectorDebuggerAgent.cpp:164
> +    RefPtr<Inspector::Protocol::Debugger::BreakpointPauseReason> reason = Inspector::Protocol::Debugger::BreakpointPauseReason::create()
> +        .setBreakpointId(it->value);

Ditto.

> Source/JavaScriptCore/inspector/agents/InspectorDebuggerAgent.cpp:431
>      RefPtr<Inspector::Protocol::Debugger::Location> location = Inspector::Protocol::Debugger::Location::create()

Ditto.

> Source/WebInspectorUI/UserInterface/Views/DebuggerSidebarPanel.js:650
> +            // FIXME: We should include the assertion condition string.

Yes!

> Source/WebInspectorUI/UserInterface/Views/DebuggerSidebarPanel.js:656
> +            }            
> +            this._pauseReasonTextRow.text = WebInspector.UIString("Assertion Failed");

Nit: Newline in the middle would look nicer.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20150107/957ccc74/attachment-0002.html>