[Webkit-unassigned] [Bug 140667] [WinCairo] Accelerated compositing should be disabled when graphics card does not support it.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=140667

Alex Christensen <achristensen at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #246402|review?                     |review-
              Flags|                            |

--- Comment #7 from Alex Christensen <achristensen at apple.com> ---
Comment on attachment 246402
  --> https://bugs.webkit.org/attachment.cgi?id=246402
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=246402&action=review

> Source/WebKit/win/WebCoreSupport/AcceleratedCompositingContext.cpp:254
> +    HWND testWindow = ::CreateWindowEx(WS_EX_NOACTIVATE, defWndProcWindowClassName(), L"AcceleratedCompositingTesterWindow", WS_POPUP | WS_VISIBLE | WS_DISABLED, -width, -height, width, height, 0, 0, 0, 0);

Is this visible?  Does it make a flash on the screen?  Does an invisible test work?

> Source/WebKit/win/WebCoreSupport/AcceleratedCompositingContext.cpp:307
> +    COLORREF pixelColor = ::GetPixel(hdc, 0, 0);

We should probably call ::SetPixel to red, swapBuffers with colorComponent as green, and then check to see if pixelColor is green.  It is unclear what the pixel would be if the test fails.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20150211/ea3ca73f/attachment-0002.html>