[Webkit-unassigned] [Bug 140667] [WinCairo] Accelerated compositing should be disabled when graphics card does not support it.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=140667

--- Comment #6 from peavo at outlook.com ---
(In reply to comment #4)
> Comment on attachment 244974 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=244974&action=review
> 

Thanks for reviewing :)

> I could see this making things a little harder to debug.  If we run into a
> problem in the future, we would also have to ask ourselves if it is a
> problem with the accelerated path or not.  Doesn't DirectX have a
> non-graphics-card implementation that ideally behaves the same, but slower? 
> Couldn't we use this through ANGLE instead of OpenGL?  If that's infeasible,
> then this is definitely the way to go.
>

That might be possible, but I'm not sure :)
I think ANGLE examines the presence of some capabilities, and will not create a renderer if the requirements are not met.

> > Source/WebKit/win/WebCoreSupport/AcceleratedCompositingContext.cpp:248
> > +bool AcceleratedCompositingContext::acceleratedCompositingAvailable()
> 
> This and the declaration should probably also be inside #if
> USE(TEXTURE_MAPPER_GL)
> 

I think the whole file is inside #if USE(TEXTURE_MAPPER_GL)

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20150211/245f4030/attachment-0002.html>