[Webkit-unassigned] [Bug 139439] [MSE] Implement Append Error algorithm.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=139439

--- Comment #9 from Jer Noble <jer.noble at apple.com> ---
(In reply to comment #8)
> > > +    // 3.1. Verify the following properties. If any of the checks fail then run the append error algorithm
> > > +    // with the decode error parameter set to true and abort these steps.
> > 
> > The documentation changed, but I don't see a call to "appendError(true)" in
> > this patch.  Is this an oversight?
> 
> It is called by SourceBuffer.cpp:941 in this patch:
> 
> if (!validateInitializationSegment(segment)) {
>  941 appendError(true);
> 
> Checks in validation were not changed, only result of fail, which is checked
> in sourceBufferPrivateDidReceiveInitializationSegment, so I changed previous
> streamEndedWithError call.
> 
> I can add comment pointing to that line if You wish?

Ah, I see now. It might be worthwhile pulling the comment starting with '3.1. Verify...' up before line 941, so it's clear what's going on. (And marking the comment inside validateInitializationSegment as '(ctd)'.)

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20150205/28c68db6/attachment-0002.html>