[Webkit-unassigned] [Bug 139439] [MSE] Implement Append Error algorithm.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Feb 5 13:00:53 PST 2015


https://bugs.webkit.org/show_bug.cgi?id=139439

--- Comment #8 from Bartlomiej Gajda <b.gajda at samsung.com> ---
> > +    // 3.1. Verify the following properties. If any of the checks fail then run the append error algorithm
> > +    // with the decode error parameter set to true and abort these steps.
> 
> The documentation changed, but I don't see a call to "appendError(true)" in
> this patch.  Is this an oversight?

It is called by SourceBuffer.cpp:941 in this patch:

if (!validateInitializationSegment(segment)) {
 941 appendError(true);

Checks in validation were not changed, only result of fail, which is checked in sourceBufferPrivateDidReceiveInitializationSegment, so I changed previous streamEndedWithError call.

I can add comment pointing to that line if You wish?

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20150205/d9644926/attachment-0002.html>


More information about the webkit-unassigned mailing list