[Webkit-unassigned] [Bug 141096] WebGL2 (3.7.1): New queries in getParameter

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=141096

--- Comment #15 from Roger Fong <roger_fong at apple.com> ---
(In reply to comment #14)
> Comment on attachment 245907 [details]
> patch part2
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=245907&action=review
> 
> r=me.
Thanks!

> 
> > Source/WebCore/html/canvas/WebGLGetInfo.cpp:122
> > +WebGLGetInfo::WebGLGetInfo(long long value)
> 
> Should this be "long long" or "int64_t"?

I'd like to use long long since that is what GC3Dint64 is defined to be and I'd like to keep things consistent with the spec.

> 
> > Source/WebCore/platform/graphics/opengl/GraphicsContext3DOpenGLCommon.cpp:1378
> > +    *value = 0;
> 
> Do we need to be concerned that value could be nullptr?

I don't think that it can be in this case since it goes through WebGLRenderingContextBase::getInt64parameter, which creates it's own "value" instance.

This is also super temporary.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20150203/e6cc29ef/attachment-0002.html>