[Webkit-unassigned] [Bug 141096] WebGL2 (3.7.1): New queries in getParameter

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=141096

Brent Fulgham <bfulgham at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #245907|review?                     |review+
              Flags|                            |

--- Comment #14 from Brent Fulgham <bfulgham at webkit.org> ---
Comment on attachment 245907
  --> https://bugs.webkit.org/attachment.cgi?id=245907
patch part2

View in context: https://bugs.webkit.org/attachment.cgi?id=245907&action=review

r=me.

> Source/WebCore/html/canvas/WebGLGetInfo.cpp:122
> +WebGLGetInfo::WebGLGetInfo(long long value)

Should this be "long long" or "int64_t"?

> Source/WebCore/platform/graphics/opengl/GraphicsContext3DOpenGLCommon.cpp:1378
> +    *value = 0;

Do we need to be concerned that value could be nullptr?

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20150203/85fb321f/attachment-0002.html>