[Webkit-unassigned] [Bug 115600] [GTK] Allow to save and restore session

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=115600

Michael Catanzaro <mcatanzaro at igalia.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |mcatanzaro at igalia.com

--- Comment #14 from Michael Catanzaro <mcatanzaro at igalia.com> ---
(In reply to comment #13)
> #if CPU(X86_64) && COMPILER(GCC_OR_CLANG) && DEVELOPER_MODE
> static_assert(sizeof(HTTPBody::Element == sizeof(Type) +
> sizeof(Vector<char>) + sizeof(String) + sizeof(int64_t) +
> sizeof(Optional<int64_t>) + sizeof(Optional<double>) + sizeof(String));
> #endif

You would then need to put __attribute__((__packed__)) on the structs, in an #ifdef, and get an owner to OK it. Maybe check && NDEBUG as well to make sure not to slow down release builds.

I think it'd be worth it, to make sure we don't miss serializing new values.

> > Source/WebKit2/ChangeLog:15
> > +        session state form the given WebKitWebViewSessionState.
> 
> form -> rom

form -> from

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20151230/7e20f05b/attachment-0001.html>