<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body><span class="vcard"><a class="email" href="mailto:mcatanzaro@igalia.com" title="Michael Catanzaro <mcatanzaro@igalia.com>"> <span class="fn">Michael Catanzaro</span></a>
</span> changed
<a class="bz_bug_link
bz_status_UNCONFIRMED "
title="UNCONFIRMED - [GTK] Allow to save and restore session"
href="https://bugs.webkit.org/show_bug.cgi?id=115600">bug 115600</a>
<br>
<table border="1" cellspacing="0" cellpadding="8">
<tr>
<th>What</th>
<th>Removed</th>
<th>Added</th>
</tr>
<tr>
<td style="text-align:right;">CC</td>
<td>
</td>
<td>mcatanzaro@igalia.com
</td>
</tr></table>
<p>
<div>
<b><a class="bz_bug_link
bz_status_UNCONFIRMED "
title="UNCONFIRMED - [GTK] Allow to save and restore session"
href="https://bugs.webkit.org/show_bug.cgi?id=115600#c14">Comment # 14</a>
on <a class="bz_bug_link
bz_status_UNCONFIRMED "
title="UNCONFIRMED - [GTK] Allow to save and restore session"
href="https://bugs.webkit.org/show_bug.cgi?id=115600">bug 115600</a>
from <span class="vcard"><a class="email" href="mailto:mcatanzaro@igalia.com" title="Michael Catanzaro <mcatanzaro@igalia.com>"> <span class="fn">Michael Catanzaro</span></a>
</span></b>
<pre>(In reply to <a href="show_bug.cgi?id=115600#c13">comment #13</a>)
<span class="quote">> #if CPU(X86_64) && COMPILER(GCC_OR_CLANG) && DEVELOPER_MODE
> static_assert(sizeof(HTTPBody::Element == sizeof(Type) +
> sizeof(Vector<char>) + sizeof(String) + sizeof(int64_t) +
> sizeof(Optional<int64_t>) + sizeof(Optional<double>) + sizeof(String));
> #endif</span >
You would then need to put __attribute__((__packed__)) on the structs, in an #ifdef, and get an owner to OK it. Maybe check && NDEBUG as well to make sure not to slow down release builds.
I think it'd be worth it, to make sure we don't miss serializing new values.
<span class="quote">> > Source/WebKit2/ChangeLog:15
> > + session state form the given WebKitWebViewSessionState.
>
> form -> rom</span >
form -> from</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>