[Webkit-unassigned] [Bug 152157] run-webkit-tests shouldn't start multiple iOS simulators while only running one test

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Dec 17 09:40:15 PST 2015


--- Comment #4 from Alexey Proskuryakov <ap at webkit.org> ---
Comment on attachment 267511
  --> https://bugs.webkit.org/attachment.cgi?id=267511
Minor improvement in Manager::_update_num_workers()

View in context: https://bugs.webkit.org/attachment.cgi?id=267511&action=review

> Tools/Scripts/webkitpy/layout_tests/controllers/layout_test_runner.py:81
> +    def get_num_workers(self, test_inputs, num_child_processes):

It still irks me to see "num" in code, WebKit coding style calls for no abbreviations. Could you please update variable and function names to avoid using "num"?

> Tools/Scripts/webkitpy/layout_tests/controllers/layout_test_runner.py:84
> +        self._printer.write_update('Number of workers: %d' % num_workers)

This is new logging, but I remember that we already print out the number of workers. Is it useful to have more? How does it the end result look?

You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20151217/c46592f2/attachment.html>

More information about the webkit-unassigned mailing list