<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - run-webkit-tests shouldn't start multiple iOS simulators while only running one test"
href="https://bugs.webkit.org/show_bug.cgi?id=152157#c4">Comment # 4</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - run-webkit-tests shouldn't start multiple iOS simulators while only running one test"
href="https://bugs.webkit.org/show_bug.cgi?id=152157">bug 152157</a>
from <span class="vcard"><a class="email" href="mailto:ap@webkit.org" title="Alexey Proskuryakov <ap@webkit.org>"> <span class="fn">Alexey Proskuryakov</span></a>
</span></b>
<pre>Comment on <span class=""><a href="attachment.cgi?id=267511&action=diff" name="attach_267511" title="Minor improvement in Manager::_update_num_workers()">attachment 267511</a> <a href="attachment.cgi?id=267511&action=edit" title="Minor improvement in Manager::_update_num_workers()">[details]</a></span>
Minor improvement in Manager::_update_num_workers()
View in context: <a href="https://bugs.webkit.org/attachment.cgi?id=267511&action=review">https://bugs.webkit.org/attachment.cgi?id=267511&action=review</a>
<span class="quote">> Tools/Scripts/webkitpy/layout_tests/controllers/layout_test_runner.py:81
> + def get_num_workers(self, test_inputs, num_child_processes):</span >
It still irks me to see "num" in code, WebKit coding style calls for no abbreviations. Could you please update variable and function names to avoid using "num"?
<span class="quote">> Tools/Scripts/webkitpy/layout_tests/controllers/layout_test_runner.py:84
> + self._printer.write_update('Number of workers: %d' % num_workers)</span >
This is new logging, but I remember that we already print out the number of workers. Is it useful to have more? How does it the end result look?</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>