[Webkit-unassigned] [Bug 152345] Teach dashboard code to compare non-integer revisions.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=152345

--- Comment #2 from Alexey Proskuryakov <ap at webkit.org> ---
Comment on attachment 267470
  --> https://bugs.webkit.org/attachment.cgi?id=267470
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=267470&action=review

I didn't review this at all, just opened at a random place and couldn't help but post a couple comments.

It's great to have tests!

> Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/index.html:5
> +    <meta charset="UTF-8" />
> +    <meta http-equiv="content-type" content="text/html; charset=utf-8" />

The first line is sufficient. Also, please don't use XML auto-closing syntax in HTML, it's invalid there.

> Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/index.html:9
> +    <link rel="stylesheet" href="https://code.jquery.com/qunit/qunit-1.20.0.css">

We try to make our tests not access external resources. There are already parts of jquery in External directory for the dashboard.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20151216/c512e6ce/attachment-0001.html>