<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - Teach dashboard code to compare non-integer revisions."
href="https://bugs.webkit.org/show_bug.cgi?id=152345#c2">Comment # 2</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - Teach dashboard code to compare non-integer revisions."
href="https://bugs.webkit.org/show_bug.cgi?id=152345">bug 152345</a>
from <span class="vcard"><a class="email" href="mailto:ap@webkit.org" title="Alexey Proskuryakov <ap@webkit.org>"> <span class="fn">Alexey Proskuryakov</span></a>
</span></b>
<pre>Comment on <span class=""><a href="attachment.cgi?id=267470&action=diff" name="attach_267470" title="Patch">attachment 267470</a> <a href="attachment.cgi?id=267470&action=edit" title="Patch">[details]</a></span>
Patch
View in context: <a href="https://bugs.webkit.org/attachment.cgi?id=267470&action=review">https://bugs.webkit.org/attachment.cgi?id=267470&action=review</a>
I didn't review this at all, just opened at a random place and couldn't help but post a couple comments.
It's great to have tests!
<span class="quote">> Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/index.html:5
> + <meta charset="UTF-8" />
> + <meta http-equiv="content-type" content="text/html; charset=utf-8" /></span >
The first line is sufficient. Also, please don't use XML auto-closing syntax in HTML, it's invalid there.
<span class="quote">> Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/index.html:9
> + <link rel="stylesheet" href="<a href="https://code.jquery.com/qunit/qunit-1.20.0.css">https://code.jquery.com/qunit/qunit-1.20.0.css</a>"></span >
We try to make our tests not access external resources. There are already parts of jquery in External directory for the dashboard.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>