[Webkit-unassigned] [Bug 150515] Safari background tabs should be fully suspended where possible.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Dec 11 23:22:58 PST 2015


Ryosuke Niwa <rniwa at webkit.org> changed:

           What    |Removed                     |Added
 Attachment #267222|review?                     |review+
              Flags|                            |

--- Comment #26 from Ryosuke Niwa <rniwa at webkit.org> ---
Comment on attachment 267222
  --> https://bugs.webkit.org/attachment.cgi?id=267222

View in context: https://bugs.webkit.org/attachment.cgi?id=267222&action=review

> Source/WebCore/history/PageCache.cpp:152
> +    if (frame.document()&&!frame.document()->canSuspendActiveDOMObjectsForDocumentSuspension(&unsuspendableObjects)) {

Nit: Need spaces around &&.

> Source/WebCore/page/Page.cpp:1840
> +    for (Frame* frame = &mainFrame(); frame; frame = frame->tree().traverseNext()) {

We can use auto* for frame as well.

> Source/WebCore/page/Page.cpp:1874
> +    setIsTabSuspended(m_shouldTabSuspend);

We don't need to check m_shouldTabSuspend since m_shouldTabSuspend should always be true at this point.
Why don't we ASSERT(m_shouldTabSuspend) instead?

You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20151212/7c007e6d/attachment-0001.html>

More information about the webkit-unassigned mailing list