<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body><span class="vcard"><a class="email" href="mailto:rniwa@webkit.org" title="Ryosuke Niwa <rniwa@webkit.org>"> <span class="fn">Ryosuke Niwa</span></a>
</span> changed
<a class="bz_bug_link
bz_status_NEW "
title="NEW - Safari background tabs should be fully suspended where possible."
href="https://bugs.webkit.org/show_bug.cgi?id=150515">bug 150515</a>
<br>
<table border="1" cellspacing="0" cellpadding="8">
<tr>
<th>What</th>
<th>Removed</th>
<th>Added</th>
</tr>
<tr>
<td style="text-align:right;">Attachment #267222 Flags</td>
<td>review?
</td>
<td>review+
</td>
</tr></table>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - Safari background tabs should be fully suspended where possible."
href="https://bugs.webkit.org/show_bug.cgi?id=150515#c26">Comment # 26</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - Safari background tabs should be fully suspended where possible."
href="https://bugs.webkit.org/show_bug.cgi?id=150515">bug 150515</a>
from <span class="vcard"><a class="email" href="mailto:rniwa@webkit.org" title="Ryosuke Niwa <rniwa@webkit.org>"> <span class="fn">Ryosuke Niwa</span></a>
</span></b>
<pre>Comment on <span class=""><a href="attachment.cgi?id=267222&action=diff" name="attach_267222" title="Patch">attachment 267222</a> <a href="attachment.cgi?id=267222&action=edit" title="Patch">[details]</a></span>
Patch
View in context: <a href="https://bugs.webkit.org/attachment.cgi?id=267222&action=review">https://bugs.webkit.org/attachment.cgi?id=267222&action=review</a>
<span class="quote">> Source/WebCore/history/PageCache.cpp:152
> + if (frame.document()&&!frame.document()->canSuspendActiveDOMObjectsForDocumentSuspension(&unsuspendableObjects)) {</span >
Nit: Need spaces around &&.
<span class="quote">> Source/WebCore/page/Page.cpp:1840
> + for (Frame* frame = &mainFrame(); frame; frame = frame->tree().traverseNext()) {</span >
We can use auto* for frame as well.
<span class="quote">> Source/WebCore/page/Page.cpp:1874
> + setIsTabSuspended(m_shouldTabSuspend);</span >
We don't need to check m_shouldTabSuspend since m_shouldTabSuspend should always be true at this point.
Why don't we ASSERT(m_shouldTabSuspend) instead?</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>