[Webkit-unassigned] [Bug 149338] [ES6] "super" and "this" should be lexically bound inside an arrow function and should live in a JSLexicalEnvironment

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=149338

Saam Barati <sbarati at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #266850|review?, commit-queue?      |review+, commit-queue-
              Flags|                            |

--- Comment #148 from Saam Barati <sbarati at apple.com> ---
Comment on attachment 266850
  --> https://bugs.webkit.org/attachment.cgi?id=266850
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=266850&action=review

> Source/JavaScriptCore/dfg/DFGByteCodeParser.cpp:4572
> +            if (opcodeID == op_new_func_exp) {
> +                // Curly braces are necessary
> +                NEXT_OPCODE(op_new_func_exp);
> +            } else {
> +                // Curly braces are necessary
> +                NEXT_OPCODE(op_new_arrow_func_exp);
> +            }

Why not just "NEXT_OPCODE(opcodeID)" ?

> Source/JavaScriptCore/llint/LowLevelInterpreter64.asm:2288
> +
> +

Revert this please.

> Source/JavaScriptCore/runtime/Executable.h:659
> +    // TODO:Think about avoid using isArrowFunction veriabl

Style: I don't think we need a variable.
WebKit style handles this is with a FIXME and not a TODO.
Also, the best FIXMEs are ones with bug numbers.
Anyways, I think for this patch this can just be removed.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20151208/9753be43/attachment.html>