<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body><span class="vcard"><a class="email" href="mailto:sbarati@apple.com" title="Saam Barati <sbarati@apple.com>"> <span class="fn">Saam Barati</span></a>
</span> changed
<a class="bz_bug_link
bz_status_REOPENED "
title="REOPENED - [ES6] "super" and "this" should be lexically bound inside an arrow function and should live in a JSLexicalEnvironment"
href="https://bugs.webkit.org/show_bug.cgi?id=149338">bug 149338</a>
<br>
<table border="1" cellspacing="0" cellpadding="8">
<tr>
<th>What</th>
<th>Removed</th>
<th>Added</th>
</tr>
<tr>
<td style="text-align:right;">Attachment #266850 Flags</td>
<td>review?, commit-queue?
</td>
<td>review+, commit-queue-
</td>
</tr></table>
<p>
<div>
<b><a class="bz_bug_link
bz_status_REOPENED "
title="REOPENED - [ES6] "super" and "this" should be lexically bound inside an arrow function and should live in a JSLexicalEnvironment"
href="https://bugs.webkit.org/show_bug.cgi?id=149338#c148">Comment # 148</a>
on <a class="bz_bug_link
bz_status_REOPENED "
title="REOPENED - [ES6] "super" and "this" should be lexically bound inside an arrow function and should live in a JSLexicalEnvironment"
href="https://bugs.webkit.org/show_bug.cgi?id=149338">bug 149338</a>
from <span class="vcard"><a class="email" href="mailto:sbarati@apple.com" title="Saam Barati <sbarati@apple.com>"> <span class="fn">Saam Barati</span></a>
</span></b>
<pre>Comment on <span class=""><a href="attachment.cgi?id=266850&action=diff" name="attach_266850" title="Patch">attachment 266850</a> <a href="attachment.cgi?id=266850&action=edit" title="Patch">[details]</a></span>
Patch
View in context: <a href="https://bugs.webkit.org/attachment.cgi?id=266850&action=review">https://bugs.webkit.org/attachment.cgi?id=266850&action=review</a>
<span class="quote">> Source/JavaScriptCore/dfg/DFGByteCodeParser.cpp:4572
> + if (opcodeID == op_new_func_exp) {
> + // Curly braces are necessary
> + NEXT_OPCODE(op_new_func_exp);
> + } else {
> + // Curly braces are necessary
> + NEXT_OPCODE(op_new_arrow_func_exp);
> + }</span >
Why not just "NEXT_OPCODE(opcodeID)" ?
<span class="quote">> Source/JavaScriptCore/llint/LowLevelInterpreter64.asm:2288
> +
> +</span >
Revert this please.
<span class="quote">> Source/JavaScriptCore/runtime/Executable.h:659
> + // TODO:Think about avoid using isArrowFunction veriabl</span >
Style: I don't think we need a variable.
WebKit style handles this is with a FIXME and not a TODO.
Also, the best FIXMEs are ones with bug numbers.
Anyways, I think for this patch this can just be removed.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>