[Webkit-unassigned] [Bug 151797] New: [GTK] Test /webkit2/WebKitWebResource/get-data is flaky

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=151797

            Bug ID: 151797
           Summary: [GTK] Test /webkit2/WebKitWebResource/get-data is
                    flaky
    Classification: Unclassified
           Product: WebKit
           Version: WebKit Local Build
          Hardware: Unspecified
                OS: Unspecified
            Status: NEW
          Keywords: Gtk
          Severity: Normal
          Priority: P2
         Component: Tools / Tests
          Assignee: webkit-unassigned at lists.webkit.org
          Reporter: cgarcia at igalia.com
                CC: lforschler at apple.com, mrobinson at webkit.org,
                    pnormand at igalia.com, zan at falconsigh.net

Since we switched to use the network process to run the unit tests the test /webkit2/WebKitWebResource/get-data sometimes fails and sometimes passes:

ERROR:../../Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestResources.cpp:194:void ResourcesTest::checkResourceData(WebKitWebResource*): code should not be reached

FAIL

This is because now the FIXME there doesn't seem to apply anymore:

// FIXME: this should be 4 instead of 3, but we don't get the css image resource
// due to bug https://bugs.webkit.org/show_bug.cgi?id=78510.
test->waitUntilResourcesLoaded(3);

We are now also getting the notification for the css image. Since we wait for 3 resources, sometimes the css image is loaded before and then checkResourceData is called for it, but not handled. When the css image is the last one loaded the test passes. So, we just need to wait for the 4 resources.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20151203/75293426/attachment.html>