<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body><table border="1" cellspacing="0" cellpadding="8">
<tr>
<th>Bug ID</th>
<td><a class="bz_bug_link
bz_status_NEW "
title="NEW - [GTK] Test /webkit2/WebKitWebResource/get-data is flaky"
href="https://bugs.webkit.org/show_bug.cgi?id=151797">151797</a>
</td>
</tr>
<tr>
<th>Summary</th>
<td>[GTK] Test /webkit2/WebKitWebResource/get-data is flaky
</td>
</tr>
<tr>
<th>Classification</th>
<td>Unclassified
</td>
</tr>
<tr>
<th>Product</th>
<td>WebKit
</td>
</tr>
<tr>
<th>Version</th>
<td>WebKit Local Build
</td>
</tr>
<tr>
<th>Hardware</th>
<td>Unspecified
</td>
</tr>
<tr>
<th>OS</th>
<td>Unspecified
</td>
</tr>
<tr>
<th>Status</th>
<td>NEW
</td>
</tr>
<tr>
<th>Keywords</th>
<td>Gtk
</td>
</tr>
<tr>
<th>Severity</th>
<td>Normal
</td>
</tr>
<tr>
<th>Priority</th>
<td>P2
</td>
</tr>
<tr>
<th>Component</th>
<td>Tools / Tests
</td>
</tr>
<tr>
<th>Assignee</th>
<td>webkit-unassigned@lists.webkit.org
</td>
</tr>
<tr>
<th>Reporter</th>
<td>cgarcia@igalia.com
</td>
</tr>
<tr>
<th>CC</th>
<td>lforschler@apple.com, mrobinson@webkit.org, pnormand@igalia.com, zan@falconsigh.net
</td>
</tr></table>
<p>
<div>
<pre>Since we switched to use the network process to run the unit tests the test /webkit2/WebKitWebResource/get-data sometimes fails and sometimes passes:
ERROR:../../Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestResources.cpp:194:void ResourcesTest::checkResourceData(WebKitWebResource*): code should not be reached
FAIL
This is because now the FIXME there doesn't seem to apply anymore:
// FIXME: this should be 4 instead of 3, but we don't get the css image resource
// due to bug <a class="bz_bug_link
bz_status_RESOLVED bz_closed"
title="RESOLVED WONTFIX - [WK2] Implement WebFrameLoaderClient::dispatchDidLoadResourceFromMemoryCache()"
href="show_bug.cgi?id=78510">https://bugs.webkit.org/show_bug.cgi?id=78510</a>.
test->waitUntilResourcesLoaded(3);
We are now also getting the notification for the css image. Since we wait for 3 resources, sometimes the css image is loaded before and then checkResourceData is called for it, but not handled. When the css image is the last one loaded the test passes. So, we just need to wait for the 4 resources.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>