[Webkit-unassigned] [Bug 151743] Move ResourceLoadScheduler to WebKit1

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=151743

Alex Christensen <achristensen at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #266456|review?                     |review+
              Flags|                            |

--- Comment #10 from Alex Christensen <achristensen at apple.com> ---
Comment on attachment 266456
  --> https://bugs.webkit.org/attachment.cgi?id=266456
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=266456&action=review

r=me with comments.

> Source/WebCore/platform/PlatformStrategies.h:90
> +    CookiesStrategy* m_cookiesStrategy { };

Is this the cool new way to say { nullptr }?

> Source/WebKit2/WebProcess/Network/WebResourceLoadScheduler.cpp:294
> +    NetworkResourceLoadParameters loadParameters;

defersLoading, needsCertificateInfo, and maximumBufferingTime seem to be uninitialized.

> Source/WebKit2/WebProcess/WebCoreSupport/WebPlatformStrategies.cpp:92
>  LoaderStrategy* WebPlatformStrategies::createLoaderStrategy()

These could probably be made to return references.

> Source/WebKit/WebCoreSupport/WebResourceLoadScheduler.cpp:64
> +    return static_cast<WebResourceLoadScheduler&>(*platformStrategies()->loaderStrategy());

Why is it ok to dereference this pointer?  I think this should be done differently.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20151202/79aaed71/attachment.html>