<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body><span class="vcard"><a class="email" href="mailto:achristensen@apple.com" title="Alex Christensen <achristensen@apple.com>"> <span class="fn">Alex Christensen</span></a>
</span> changed
<a class="bz_bug_link
bz_status_NEW "
title="NEW - Move ResourceLoadScheduler to WebKit1"
href="https://bugs.webkit.org/show_bug.cgi?id=151743">bug 151743</a>
<br>
<table border="1" cellspacing="0" cellpadding="8">
<tr>
<th>What</th>
<th>Removed</th>
<th>Added</th>
</tr>
<tr>
<td style="text-align:right;">Attachment #266456 Flags</td>
<td>review?
</td>
<td>review+
</td>
</tr></table>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - Move ResourceLoadScheduler to WebKit1"
href="https://bugs.webkit.org/show_bug.cgi?id=151743#c10">Comment # 10</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - Move ResourceLoadScheduler to WebKit1"
href="https://bugs.webkit.org/show_bug.cgi?id=151743">bug 151743</a>
from <span class="vcard"><a class="email" href="mailto:achristensen@apple.com" title="Alex Christensen <achristensen@apple.com>"> <span class="fn">Alex Christensen</span></a>
</span></b>
<pre>Comment on <span class=""><a href="attachment.cgi?id=266456&action=diff" name="attach_266456" title="patch">attachment 266456</a> <a href="attachment.cgi?id=266456&action=edit" title="patch">[details]</a></span>
patch
View in context: <a href="https://bugs.webkit.org/attachment.cgi?id=266456&action=review">https://bugs.webkit.org/attachment.cgi?id=266456&action=review</a>
r=me with comments.
<span class="quote">> Source/WebCore/platform/PlatformStrategies.h:90
> + CookiesStrategy* m_cookiesStrategy { };</span >
Is this the cool new way to say { nullptr }?
<span class="quote">> Source/WebKit2/WebProcess/Network/WebResourceLoadScheduler.cpp:294
> + NetworkResourceLoadParameters loadParameters;</span >
defersLoading, needsCertificateInfo, and maximumBufferingTime seem to be uninitialized.
<span class="quote">> Source/WebKit2/WebProcess/WebCoreSupport/WebPlatformStrategies.cpp:92
> LoaderStrategy* WebPlatformStrategies::createLoaderStrategy()</span >
These could probably be made to return references.
<span class="quote">> Source/WebKit/WebCoreSupport/WebResourceLoadScheduler.cpp:64
> + return static_cast<WebResourceLoadScheduler&>(*platformStrategies()->loaderStrategy());</span >
Why is it ok to dereference this pointer? I think this should be done differently.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>