[Webkit-unassigned] [Bug 151596] [JSC] add missing RequireObjectCoercible() step in destructuring

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Dec 1 09:28:13 PST 2015


--- Comment #12 from Darin Adler <darin at apple.com> ---
Comment on attachment 266354
  --> https://bugs.webkit.org/attachment.cgi?id=266354
[JSC] add missing RequireObjectCoercible() step in destructuring

View in context: https://bugs.webkit.org/attachment.cgi?id=266354&action=review

>> Source/JavaScriptCore/bytecompiler/BytecodeGenerator.cpp:3986
>> +    emitOpcode(op_jneq_null);
> I think we should have a FIXME right here explaining that this doesn’t do the right thing for “masquerades as undefined”; small performance and correctness problem.

We want to keep the comment short, but we also want it to address the issues Geoff mentioned; state that it’s worth having this small performance and correctness problem to keep from having to add a new opcode just for this.

You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20151201/f617c79f/attachment.html>

More information about the webkit-unassigned mailing list