<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - [JSC] add missing RequireObjectCoercible() step in destructuring"
href="https://bugs.webkit.org/show_bug.cgi?id=151596#c12">Comment # 12</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - [JSC] add missing RequireObjectCoercible() step in destructuring"
href="https://bugs.webkit.org/show_bug.cgi?id=151596">bug 151596</a>
from <span class="vcard"><a class="email" href="mailto:darin@apple.com" title="Darin Adler <darin@apple.com>"> <span class="fn">Darin Adler</span></a>
</span></b>
<pre>Comment on <span class=""><a href="attachment.cgi?id=266354&action=diff" name="attach_266354" title="[JSC] add missing RequireObjectCoercible() step in destructuring">attachment 266354</a> <a href="attachment.cgi?id=266354&action=edit" title="[JSC] add missing RequireObjectCoercible() step in destructuring">[details]</a></span>
[JSC] add missing RequireObjectCoercible() step in destructuring
View in context: <a href="https://bugs.webkit.org/attachment.cgi?id=266354&action=review">https://bugs.webkit.org/attachment.cgi?id=266354&action=review</a>
<span class="quote">>> Source/JavaScriptCore/bytecompiler/BytecodeGenerator.cpp:3986
>> + emitOpcode(op_jneq_null);
>
> I think we should have a FIXME right here explaining that this doesn’t do the right thing for “masquerades as undefined”; small performance and correctness problem.</span >
We want to keep the comment short, but we also want it to address the issues Geoff mentioned; state that it’s worth having this small performance and correctness problem to keep from having to add a new opcode just for this.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>