[Webkit-unassigned] [Bug 148373] Create WebAssembly functions

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=148373

--- Comment #24 from Sukolsak Sakshuwong <sukolsak at gmail.com> ---
(In reply to comment #21)
> Comment on attachment 260130 [details]
>
> So we need to insert executable->isWebAssemblyExecutable() case here (of
> course, Internals is just used for the tests. So this assertion never occurs
> in the production I think.)

Thanks. I have added the following diff to WebCore/testing/Internals.cpp

@@ -1485,10 +1485,14 @@ String Internals::parserMetaData(Deprecated::ScriptValue value)
         result.append('"');
     } else if (executable->isEvalExecutable())
         result.appendLiteral("eval");
-    else {
-        ASSERT(executable->isProgramExecutable());
+    else if (executable->isProgramExecutable())
         result.appendLiteral("program");
-    }
+#if ENABLE(WEBASSEMBLY)
+    else if (executable->isWebAssemblyExecutable())
+        result.appendLiteral("WebAssembly");
+#endif
+    else
+        ASSERT_NOT_REACHED();

     result.appendLiteral(" { ");
     result.appendNumber(startLine);

As you wrote, Internals is just used for the tests. The code that I added ('result.appendLiteral("WebAssembly");') will never be executed, because we are currently not testing WebAssembly. But even if we test it, I'm wondering whether this code will ever be reached, given how WebAssembly is loaded.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20150828/29af9b27/attachment.html>