<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body>
<p>
<div>
<b><a class="bz_bug_link
bz_status_REOPENED "
title="REOPENED - Create WebAssembly functions"
href="https://bugs.webkit.org/show_bug.cgi?id=148373#c24">Comment # 24</a>
on <a class="bz_bug_link
bz_status_REOPENED "
title="REOPENED - Create WebAssembly functions"
href="https://bugs.webkit.org/show_bug.cgi?id=148373">bug 148373</a>
from <span class="vcard"><a class="email" href="mailto:sukolsak@gmail.com" title="Sukolsak Sakshuwong <sukolsak@gmail.com>"> <span class="fn">Sukolsak Sakshuwong</span></a>
</span></b>
<pre>(In reply to <a href="show_bug.cgi?id=148373#c21">comment #21</a>)
<span class="quote">> Comment on <span class="bz_obsolete"><a href="attachment.cgi?id=260130&action=diff" name="attach_260130" title="Patch">attachment 260130</a> <a href="attachment.cgi?id=260130&action=edit" title="Patch">[details]</a></span></span >
>
<span class="quote">> So we need to insert executable->isWebAssemblyExecutable() case here (of
> course, Internals is just used for the tests. So this assertion never occurs
> in the production I think.)</span >
Thanks. I have added the following diff to WebCore/testing/Internals.cpp
@@ -1485,10 +1485,14 @@ String Internals::parserMetaData(Deprecated::ScriptValue value)
result.append('"');
} else if (executable->isEvalExecutable())
result.appendLiteral("eval");
- else {
- ASSERT(executable->isProgramExecutable());
+ else if (executable->isProgramExecutable())
result.appendLiteral("program");
- }
+#if ENABLE(WEBASSEMBLY)
+ else if (executable->isWebAssemblyExecutable())
+ result.appendLiteral("WebAssembly");
+#endif
+ else
+ ASSERT_NOT_REACHED();
result.appendLiteral(" { ");
result.appendNumber(startLine);
As you wrote, Internals is just used for the tests. The code that I added ('result.appendLiteral("WebAssembly");') will never be executed, because we are currently not testing WebAssembly. But even if we test it, I'm wondering whether this code will ever be reached, given how WebAssembly is loaded.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>