[Webkit-unassigned] [Bug 148373] Create WebAssembly functions

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=148373

--- Comment #21 from Yusuke Suzuki <utatane.tea at gmail.com> ---
Comment on attachment 260130
  --> https://bugs.webkit.org/attachment.cgi?id=260130
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=260130&action=review

> Source/WebCore/testing/Internals.cpp:1469
>          executable = funcObj->jsExecutable();

FYI, during implementing ModuleProgramExecutable in my module patch, I found the following code in WebCore Internals.cpp

if (executable->isFunctionExecutable()) {
    ...
} else if (executable->isEvalExecutable())
    result.appendLiteral("eval");
else {
    ASSERT(executable->isProgramExecutable());
    ...
}

So we need to insert executable->isWebAssemblyExecutable() case here (of course, Internals is just used for the tests. So this assertion never occurs in the production I think.)

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20150828/482c83fa/attachment.html>