<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body>
<p>
<div>
<b><a class="bz_bug_link
bz_status_REOPENED "
title="REOPENED - Create WebAssembly functions"
href="https://bugs.webkit.org/show_bug.cgi?id=148373#c21">Comment # 21</a>
on <a class="bz_bug_link
bz_status_REOPENED "
title="REOPENED - Create WebAssembly functions"
href="https://bugs.webkit.org/show_bug.cgi?id=148373">bug 148373</a>
from <span class="vcard"><a class="email" href="mailto:utatane.tea@gmail.com" title="Yusuke Suzuki <utatane.tea@gmail.com>"> <span class="fn">Yusuke Suzuki</span></a>
</span></b>
<pre>Comment on <span class=""><a href="attachment.cgi?id=260130&action=diff" name="attach_260130" title="Patch">attachment 260130</a> <a href="attachment.cgi?id=260130&action=edit" title="Patch">[details]</a></span>
Patch
View in context: <a href="https://bugs.webkit.org/attachment.cgi?id=260130&action=review">https://bugs.webkit.org/attachment.cgi?id=260130&action=review</a>
<span class="quote">> Source/WebCore/testing/Internals.cpp:1469
> executable = funcObj->jsExecutable();</span >
FYI, during implementing ModuleProgramExecutable in my module patch, I found the following code in WebCore Internals.cpp
if (executable->isFunctionExecutable()) {
...
} else if (executable->isEvalExecutable())
result.appendLiteral("eval");
else {
ASSERT(executable->isProgramExecutable());
...
}
So we need to insert executable->isWebAssemblyExecutable() case here (of course, Internals is just used for the tests. So this assertion never occurs in the production I think.)</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>