[Webkit-unassigned] [Bug 148507] Add a Layout test for r188991

Wed Aug 26 21:57:26 PDT 2015

https://bugs.webkit.org/show_bug.cgi?id=148507

--- Comment #8 from Tim Horton <thorton at apple.com> ---
Comment on attachment 260027
  --> https://bugs.webkit.org/attachment.cgi?id=260027
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=260027&action=review

> LayoutTests/ChangeLog:8
> +        Tests that stopping an animation early and simultaneously closing the window

So glad that there's a test! It's not simultaneous, though :P

> LayoutTests/animations/crash-on-removing-animation.html:24
> +        if (window.testRunner == undefined)

No need for the == undefined; every other test just does "if (window.testRunner)". Also possible that you might want to document.write("This test must be run in DRT/WKTR.") or something like that so that people (QA, mostly) don't open the test and see "If you are reading this, we managed to avoid crashing!" and think that the test passed.

> LayoutTests/animations/crash-on-removing-animation.html:44
> +<body onload="setup();">

No need for the semicolon, and it looks funny, but it doesn't really matter.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20150827/c2df3f58/attachment.html>