<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - Add a Layout test for r188991"
href="https://bugs.webkit.org/show_bug.cgi?id=148507#c8">Comment # 8</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - Add a Layout test for r188991"
href="https://bugs.webkit.org/show_bug.cgi?id=148507">bug 148507</a>
from <span class="vcard"><a class="email" href="mailto:thorton@apple.com" title="Tim Horton <thorton@apple.com>"> <span class="fn">Tim Horton</span></a>
</span></b>
<pre>Comment on <span class=""><a href="attachment.cgi?id=260027&action=diff" name="attach_260027" title="Patch">attachment 260027</a> <a href="attachment.cgi?id=260027&action=edit" title="Patch">[details]</a></span>
Patch
View in context: <a href="https://bugs.webkit.org/attachment.cgi?id=260027&action=review">https://bugs.webkit.org/attachment.cgi?id=260027&action=review</a>
<span class="quote">> LayoutTests/ChangeLog:8
> + Tests that stopping an animation early and simultaneously closing the window</span >
So glad that there's a test! It's not simultaneous, though :P
<span class="quote">> LayoutTests/animations/crash-on-removing-animation.html:24
> + if (window.testRunner == undefined)</span >
No need for the == undefined; every other test just does "if (window.testRunner)". Also possible that you might want to document.write("This test must be run in DRT/WKTR.") or something like that so that people (QA, mostly) don't open the test and see "If you are reading this, we managed to avoid crashing!" and think that the test passed.
<span class="quote">> LayoutTests/animations/crash-on-removing-animation.html:44
> +<body onload="setup();"></span >
No need for the semicolon, and it looks funny, but it doesn't really matter.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>