[Webkit-unassigned] [Bug 148197] iOS Simulator layout-tests fail to start while cleaning a directory structure if simulator is already running

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=148197

Daniel Bates <dbates at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #259884|review?                     |review+
              Flags|                            |

--- Comment #9 from Daniel Bates <dbates at webkit.org> ---
Comment on attachment 259884
  --> https://bugs.webkit.org/attachment.cgi?id=259884
Proposed patch

View in context: https://bugs.webkit.org/attachment.cgi?id=259884&action=review

> Tools/ChangeLog:12
> +        (IOSSimulatorPort._quitIOSSimulator): common function to quit IOSSimulator.

Nit: common => Common
IOSSimulator => iOS Simulator

> Tools/ChangeLog:14
> +        (IOSSimulatorPort.check_sys_deps): No need to quit the simulator here as its now being quit in reset_preferences.

Nit: reset_preferences => reset_preferences()

> Tools/Scripts/webkitpy/port/ios.py:80
> +    SIMULATOR_BUNDLE_ID = "com.apple.iphonesimulator"

Nit: ' (single quote) => " (double quote)

> Tools/Scripts/webkitpy/port/ios.py:213
> +    def _quitIOSSimulator(self):

I didn't meant to steer you wrong on the naming of this function. We name functions with underscores between words. So, this function should be named _quit_ios_simulator.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20150825/565af1c5/attachment.html>