<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body><span class="vcard"><a class="email" href="mailto:dbates@webkit.org" title="Daniel Bates <dbates@webkit.org>"> <span class="fn">Daniel Bates</span></a>
</span> changed
<a class="bz_bug_link
bz_status_NEW "
title="NEW - iOS Simulator layout-tests fail to start while cleaning a directory structure if simulator is already running"
href="https://bugs.webkit.org/show_bug.cgi?id=148197">bug 148197</a>
<br>
<table border="1" cellspacing="0" cellpadding="8">
<tr>
<th>What</th>
<th>Removed</th>
<th>Added</th>
</tr>
<tr>
<td style="text-align:right;">Attachment #259884 Flags</td>
<td>review?
</td>
<td>review+
</td>
</tr></table>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - iOS Simulator layout-tests fail to start while cleaning a directory structure if simulator is already running"
href="https://bugs.webkit.org/show_bug.cgi?id=148197#c9">Comment # 9</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - iOS Simulator layout-tests fail to start while cleaning a directory structure if simulator is already running"
href="https://bugs.webkit.org/show_bug.cgi?id=148197">bug 148197</a>
from <span class="vcard"><a class="email" href="mailto:dbates@webkit.org" title="Daniel Bates <dbates@webkit.org>"> <span class="fn">Daniel Bates</span></a>
</span></b>
<pre>Comment on <span class=""><a href="attachment.cgi?id=259884&action=diff" name="attach_259884" title="Proposed patch">attachment 259884</a> <a href="attachment.cgi?id=259884&action=edit" title="Proposed patch">[details]</a></span>
Proposed patch
View in context: <a href="https://bugs.webkit.org/attachment.cgi?id=259884&action=review">https://bugs.webkit.org/attachment.cgi?id=259884&action=review</a>
<span class="quote">> Tools/ChangeLog:12
> + (IOSSimulatorPort._quitIOSSimulator): common function to quit IOSSimulator.</span >
Nit: common => Common
IOSSimulator => iOS Simulator
<span class="quote">> Tools/ChangeLog:14
> + (IOSSimulatorPort.check_sys_deps): No need to quit the simulator here as its now being quit in reset_preferences.</span >
Nit: reset_preferences => reset_preferences()
<span class="quote">> Tools/Scripts/webkitpy/port/ios.py:80
> + SIMULATOR_BUNDLE_ID = "com.apple.iphonesimulator"</span >
Nit: ' (single quote) => " (double quote)
<span class="quote">> Tools/Scripts/webkitpy/port/ios.py:213
> + def _quitIOSSimulator(self):</span >
I didn't meant to steer you wrong on the naming of this function. We name functions with underscores between words. So, this function should be named _quit_ios_simulator.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>