[Webkit-unassigned] [Bug 148377] [EFL] REGRESSION: All performance tests crash

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=148377

--- Comment #4 from Gyuyoung Kim <gyuyoung.kim at webkit.org> ---
(In reply to comment #3)
> It looks like we don't have a view yet when TestController::initialize tries
> to set some prefs (via resetPreferencesToConsistentValues).
> 
> This is OK on PLATFORM(COCOA) because we keep around a global
> WKWebViewConfiguration and use that when retrieving the WKPreferences. Maybe
> someone from EFL or GTK (who can actually test this) can do the same with
> the WKPageConfiguration?

I simply apply below fix in order to run layout test on EFL port.


--- a/Tools/WebKitTestRunner/TestController.cpp
+++ b/Tools/WebKitTestRunner/TestController.cpp
@@ -568,7 +568,11 @@ void TestController::ensureViewSupportsOptionsForTest(const TestInvocation& test
 void TestController::resetPreferencesToConsistentValues()
 {
     // Reset preferences
+#if PLATFORM(COCOA)
     WKPreferencesRef preferences = platformPreferences();
+#else
+    WKPreferencesRef preferences = WKPageGroupGetPreferences(m_pageGroup.get());
+#endif


EFL layout test begins to run again with this fix. However I'm not sure if this is correct fix for EFL and GTK. Tim, what do you think ?

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20150825/0ab1df95/attachment.html>