<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - [EFL] REGRESSION: All performance tests crash"
href="https://bugs.webkit.org/show_bug.cgi?id=148377#c4">Comment # 4</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - [EFL] REGRESSION: All performance tests crash"
href="https://bugs.webkit.org/show_bug.cgi?id=148377">bug 148377</a>
from <span class="vcard"><a class="email" href="mailto:gyuyoung.kim@webkit.org" title="Gyuyoung Kim <gyuyoung.kim@webkit.org>"> <span class="fn">Gyuyoung Kim</span></a>
</span></b>
<pre>(In reply to <a href="show_bug.cgi?id=148377#c3">comment #3</a>)
<span class="quote">> It looks like we don't have a view yet when TestController::initialize tries
> to set some prefs (via resetPreferencesToConsistentValues).
>
> This is OK on PLATFORM(COCOA) because we keep around a global
> WKWebViewConfiguration and use that when retrieving the WKPreferences. Maybe
> someone from EFL or GTK (who can actually test this) can do the same with
> the WKPageConfiguration?</span >
I simply apply below fix in order to run layout test on EFL port.
--- a/Tools/WebKitTestRunner/TestController.cpp
+++ b/Tools/WebKitTestRunner/TestController.cpp
@@ -568,7 +568,11 @@ void TestController::ensureViewSupportsOptionsForTest(const TestInvocation& test
void TestController::resetPreferencesToConsistentValues()
{
// Reset preferences
+#if PLATFORM(COCOA)
WKPreferencesRef preferences = platformPreferences();
+#else
+ WKPreferencesRef preferences = WKPageGroupGetPreferences(m_pageGroup.get());
+#endif
EFL layout test begins to run again with this fix. However I'm not sure if this is correct fix for EFL and GTK. Tim, what do you think ?</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>