[Webkit-unassigned] [Bug 148188] Make Dashboard.Branches be objects of the form {repository, branchName} and update existing code to work with these new objects.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=148188

Daniel Bates <dbates at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #259676|review?, commit-queue?      |review+, commit-queue-
              Flags|                            |

--- Comment #8 from Daniel Bates <dbates at webkit.org> ---
Comment on attachment 259676
  --> https://bugs.webkit.org/attachment.cgi?id=259676
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=259676&action=review

> Tools/ChangeLog:12
> +        (BuildbotCombinedQueueView): Changed to work with new {repository, branchName} object.

Maybe it would be more descriptive to write:

Changed to work with new branch objects which represent a (repository, "branch name")-pair.

> Tools/ChangeLog:18
> +        (BuildbotQueueView.prototype._appendPendingRevisionCount): Changed to work with new {repository, branchName}
> +        object.

Ditto.

> Tools/ChangeLog:24
> +        * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Dashboard.js: Added isSVN property
> +        to Dashboard.Repository object. Also removed Internal Dashboard.Repository object.

I'm unclear how these change relate to the purpose of this bug. Please make these change in a separate bug.

> Tools/ChangeLog:28
> +        (WebKitBuildbot.prototype.get defaultBranches): Changed to new {repository, branchName} format.

Maybe it would be more descriptive to write:

Changed to work with new branch objects which represent a (repository, "branch name")-pair.

> Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotCombinedQueueView.js:41
> +                indicesOfFirstQueueWithRepository[repositoryName] = {queueIndex: i, branchIndex: j};

Nit: There should be a space character after the '{' and before the '}';

> Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotCombinedQueueView.js:46
> +            message += " === combinedQueues[" + expected.queueIndex + "].branch[" + expected.branchIndex + "] === " + expectedBranch.name;

Nit: Remove the space character at the beginning of this line or there will be two space characters before the second === in the printed message.

> Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Dashboard.js:40
> -        OpenSource: { name: "openSource", order: 0 },
> -        Internal: { name: "internal", order: 1 },
> +        OpenSource: { isSVN: true, name: "openSource", order: 0 },

I'm unclear how these change relate to the purpose of this bug. Please make these change in a separate bug.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20150822/16b9e2fb/attachment.html>