<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body><span class="vcard"><a class="email" href="mailto:dbates@webkit.org" title="Daniel Bates <dbates@webkit.org>"> <span class="fn">Daniel Bates</span></a>
</span> changed
<a class="bz_bug_link
bz_status_NEW "
title="NEW - Make Dashboard.Branches be objects of the form {repository, branchName} and update existing code to work with these new objects."
href="https://bugs.webkit.org/show_bug.cgi?id=148188">bug 148188</a>
<br>
<table border="1" cellspacing="0" cellpadding="8">
<tr>
<th>What</th>
<th>Removed</th>
<th>Added</th>
</tr>
<tr>
<td style="text-align:right;">Attachment #259676 Flags</td>
<td>review?, commit-queue?
</td>
<td>review+, commit-queue-
</td>
</tr></table>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - Make Dashboard.Branches be objects of the form {repository, branchName} and update existing code to work with these new objects."
href="https://bugs.webkit.org/show_bug.cgi?id=148188#c8">Comment # 8</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - Make Dashboard.Branches be objects of the form {repository, branchName} and update existing code to work with these new objects."
href="https://bugs.webkit.org/show_bug.cgi?id=148188">bug 148188</a>
from <span class="vcard"><a class="email" href="mailto:dbates@webkit.org" title="Daniel Bates <dbates@webkit.org>"> <span class="fn">Daniel Bates</span></a>
</span></b>
<pre>Comment on <span class=""><a href="attachment.cgi?id=259676&action=diff" name="attach_259676" title="Patch">attachment 259676</a> <a href="attachment.cgi?id=259676&action=edit" title="Patch">[details]</a></span>
Patch
View in context: <a href="https://bugs.webkit.org/attachment.cgi?id=259676&action=review">https://bugs.webkit.org/attachment.cgi?id=259676&action=review</a>
<span class="quote">> Tools/ChangeLog:12
> + (BuildbotCombinedQueueView): Changed to work with new {repository, branchName} object.</span >
Maybe it would be more descriptive to write:
Changed to work with new branch objects which represent a (repository, "branch name")-pair.
<span class="quote">> Tools/ChangeLog:18
> + (BuildbotQueueView.prototype._appendPendingRevisionCount): Changed to work with new {repository, branchName}
> + object.</span >
Ditto.
<span class="quote">> Tools/ChangeLog:24
> + * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Dashboard.js: Added isSVN property
> + to Dashboard.Repository object. Also removed Internal Dashboard.Repository object.</span >
I'm unclear how these change relate to the purpose of this bug. Please make these change in a separate bug.
<span class="quote">> Tools/ChangeLog:28
> + (WebKitBuildbot.prototype.get defaultBranches): Changed to new {repository, branchName} format.</span >
Maybe it would be more descriptive to write:
Changed to work with new branch objects which represent a (repository, "branch name")-pair.
<span class="quote">> Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotCombinedQueueView.js:41
> + indicesOfFirstQueueWithRepository[repositoryName] = {queueIndex: i, branchIndex: j};</span >
Nit: There should be a space character after the '{' and before the '}';
<span class="quote">> Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotCombinedQueueView.js:46
> + message += " === combinedQueues[" + expected.queueIndex + "].branch[" + expected.branchIndex + "] === " + expectedBranch.name;</span >
Nit: Remove the space character at the beginning of this line or there will be two space characters before the second === in the printed message.
<span class="quote">> Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Dashboard.js:40
> - OpenSource: { name: "openSource", order: 0 },
> - Internal: { name: "internal", order: 1 },
> + OpenSource: { isSVN: true, name: "openSource", order: 0 },</span >
I'm unclear how these change relate to the purpose of this bug. Please make these change in a separate bug.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>