[Webkit-unassigned] [Bug 148035] [ES6] Add TypedArray.prototype functionality.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=148035

--- Comment #23 from Geoffrey Garen <ggaren at apple.com> ---
Comment on attachment 259427
  --> https://bugs.webkit.org/attachment.cgi?id=259427
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=259427&action=review

> Source/JavaScriptCore/runtime/JSTypedArrayViewPrototypeInlines.h:37
> +#define CALL_GENERIC_TYPEDARRAY_PROTOTYPE_FUNCTION(functionName) do {                           \

You should just use an inline function here. It's easier to debug and not any slower.

> Source/JavaScriptCore/runtime/JSTypedArrayViewPrototypeInlines.h:65
> +static EncodedJSValue JSC_HOST_CALL typedArrayViewPrivateFuncLength(ExecState* exec)

Why are all of these functions in an Inlines.h file? It seems that we never inline them.

I think all of this stuff belongs in a .cpp file somewhere.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20150821/cc01c7e8/attachment.html>