<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - [ES6] Add TypedArray.prototype functionality."
href="https://bugs.webkit.org/show_bug.cgi?id=148035#c23">Comment # 23</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - [ES6] Add TypedArray.prototype functionality."
href="https://bugs.webkit.org/show_bug.cgi?id=148035">bug 148035</a>
from <span class="vcard"><a class="email" href="mailto:ggaren@apple.com" title="Geoffrey Garen <ggaren@apple.com>"> <span class="fn">Geoffrey Garen</span></a>
</span></b>
<pre>Comment on <span class=""><a href="attachment.cgi?id=259427&action=diff" name="attach_259427" title="Patch">attachment 259427</a> <a href="attachment.cgi?id=259427&action=edit" title="Patch">[details]</a></span>
Patch
View in context: <a href="https://bugs.webkit.org/attachment.cgi?id=259427&action=review">https://bugs.webkit.org/attachment.cgi?id=259427&action=review</a>
<span class="quote">> Source/JavaScriptCore/runtime/JSTypedArrayViewPrototypeInlines.h:37
> +#define CALL_GENERIC_TYPEDARRAY_PROTOTYPE_FUNCTION(functionName) do { \</span >
You should just use an inline function here. It's easier to debug and not any slower.
<span class="quote">> Source/JavaScriptCore/runtime/JSTypedArrayViewPrototypeInlines.h:65
> +static EncodedJSValue JSC_HOST_CALL typedArrayViewPrivateFuncLength(ExecState* exec)</span >
Why are all of these functions in an Inlines.h file? It seems that we never inline them.
I think all of this stuff belongs in a .cpp file somewhere.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>