[Webkit-unassigned] [Bug 148289] Media Session: let UI clients change the volume of the focused media element

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Aug 21 09:12:06 PDT 2015


--- Comment #3 from Eric Carlson <eric.carlson at apple.com> ---
Comment on attachment 259583
  --> https://bugs.webkit.org/attachment.cgi?id=259583

View in context: https://bugs.webkit.org/attachment.cgi?id=259583&action=review

Looks good to me.

> Source/WebCore/page/Page.cpp:1232
> +        ExceptionCode code;
> +        element->setVolume(volume, code);

Nit: you should use ASSERT_NO_EXCEPTION here.

You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20150821/1f34bd9b/attachment.html>

More information about the webkit-unassigned mailing list