<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - Media Session: let UI clients change the volume of the focused media element"
href="https://bugs.webkit.org/show_bug.cgi?id=148289#c3">Comment # 3</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - Media Session: let UI clients change the volume of the focused media element"
href="https://bugs.webkit.org/show_bug.cgi?id=148289">bug 148289</a>
from <span class="vcard"><a class="email" href="mailto:eric.carlson@apple.com" title="Eric Carlson <eric.carlson@apple.com>"> <span class="fn">Eric Carlson</span></a>
</span></b>
<pre>Comment on <span class=""><a href="attachment.cgi?id=259583&action=diff" name="attach_259583" title="Patch">attachment 259583</a> <a href="attachment.cgi?id=259583&action=edit" title="Patch">[details]</a></span>
Patch
View in context: <a href="https://bugs.webkit.org/attachment.cgi?id=259583&action=review">https://bugs.webkit.org/attachment.cgi?id=259583&action=review</a>
Looks good to me.
<span class="quote">> Source/WebCore/page/Page.cpp:1232
> + ExceptionCode code;
> + element->setVolume(volume, code);</span >
Nit: you should use ASSERT_NO_EXCEPTION here.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>