[Webkit-unassigned] [Bug 147320] Use _NSScrollingPredominantAxisFilter for wheel event filtering on Mac

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=147320

--- Comment #18 from Wenson Hsieh <wenson_hsieh at apple.com> ---
Comment on attachment 259483
  --> https://bugs.webkit.org/attachment.cgi?id=259483
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=259483&action=review

Thanks for the review! I just put up a v2 that addresses all of the points.

>> Source/WebCore/page/WheelEventDeltaFilter.cpp:34
>> +    : m_currentFilteredDelta(0, 0)
> 
> No need to initialize FloatSize.

Removed.

>> Source/WebCore/page/WheelEventDeltaFilter.cpp:44
>> +    , m_deltaTracker(WheelEventDeltaTracker())
> 
> No need to explicitly call zero-argument constructor.

Removed.

>> Source/WebCore/page/WheelEventDeltaFilter.h:50
>> +class WheelEventDeltaFilterPlatformInvariant final : public WheelEventDeltaFilter {
> 
> "PlatformInvariant" seems like naming overkill. Maybe BasicWheelEventDeltaFilter

Renamed to BasicWheelEventDeltaFilter.

>> Source/WebCore/page/WheelEventDeltaFilter.h:60
>> +    WheelEventDeltaTracker m_deltaTracker;
> 
> Why does WheelEventDeltaTracker exist independently from this class? Can it just be merged into this?

Good point -- it's not being used outside of this context anywhere else in WebKit. Done!

>> Source/WebCore/page/mac/WheelEventDeltaFilterMac.mm:31
>> +#import <AppKit/NSScrollingInputFilter_Private.h>
> 
> This will need some SPI header stuff.

Added NSScrollingInputFilterSPI.h.

>> Source/WebCore/page/mac/WheelEventDeltaFilterMac.mm:83
>> +}
> 
> These could all be inline.

Fixed.

>> Source/WebKit2/WebProcess/WebPage/EventDispatcher.cpp:66
>> +#endif
> 
> Shame to see all this here. Maybe add static WheelEventDeltaFilter::create() which is implemented per-platform.

Sounds good. Fixed.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20150820/03028d6c/attachment.html>