<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - Use _NSScrollingPredominantAxisFilter for wheel event filtering on Mac"
href="https://bugs.webkit.org/show_bug.cgi?id=147320#c18">Comment # 18</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - Use _NSScrollingPredominantAxisFilter for wheel event filtering on Mac"
href="https://bugs.webkit.org/show_bug.cgi?id=147320">bug 147320</a>
from <span class="vcard"><a class="email" href="mailto:wenson_hsieh@apple.com" title="Wenson Hsieh <wenson_hsieh@apple.com>"> <span class="fn">Wenson Hsieh</span></a>
</span></b>
<pre>Comment on <span class="bz_obsolete"><a href="attachment.cgi?id=259483&action=diff" name="attach_259483" title="Patch">attachment 259483</a> <a href="attachment.cgi?id=259483&action=edit" title="Patch">[details]</a></span>
Patch
View in context: <a href="https://bugs.webkit.org/attachment.cgi?id=259483&action=review">https://bugs.webkit.org/attachment.cgi?id=259483&action=review</a>
Thanks for the review! I just put up a v2 that addresses all of the points.
<span class="quote">>> Source/WebCore/page/WheelEventDeltaFilter.cpp:34
>> + : m_currentFilteredDelta(0, 0)
>
> No need to initialize FloatSize.</span >
Removed.
<span class="quote">>> Source/WebCore/page/WheelEventDeltaFilter.cpp:44
>> + , m_deltaTracker(WheelEventDeltaTracker())
>
> No need to explicitly call zero-argument constructor.</span >
Removed.
<span class="quote">>> Source/WebCore/page/WheelEventDeltaFilter.h:50
>> +class WheelEventDeltaFilterPlatformInvariant final : public WheelEventDeltaFilter {
>
> "PlatformInvariant" seems like naming overkill. Maybe BasicWheelEventDeltaFilter</span >
Renamed to BasicWheelEventDeltaFilter.
<span class="quote">>> Source/WebCore/page/WheelEventDeltaFilter.h:60
>> + WheelEventDeltaTracker m_deltaTracker;
>
> Why does WheelEventDeltaTracker exist independently from this class? Can it just be merged into this?</span >
Good point -- it's not being used outside of this context anywhere else in WebKit. Done!
<span class="quote">>> Source/WebCore/page/mac/WheelEventDeltaFilterMac.mm:31
>> +#import <AppKit/NSScrollingInputFilter_Private.h>
>
> This will need some SPI header stuff.</span >
Added NSScrollingInputFilterSPI.h.
<span class="quote">>> Source/WebCore/page/mac/WheelEventDeltaFilterMac.mm:83
>> +}
>
> These could all be inline.</span >
Fixed.
<span class="quote">>> Source/WebKit2/WebProcess/WebPage/EventDispatcher.cpp:66
>> +#endif
>
> Shame to see all this here. Maybe add static WheelEventDeltaFilter::create() which is implemented per-platform.</span >
Sounds good. Fixed.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>