[Webkit-unassigned] [Bug 148109] Media Session: don't begin listening for interruptions when an interruption provider is created

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Aug 18 18:04:13 PDT 2015


https://bugs.webkit.org/show_bug.cgi?id=148109

--- Comment #4 from Matt Rajca <mrajca at apple.com> ---
(In reply to comment #3)
> Comment on attachment 259212 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=259212&action=review
> 
> > Source/WebCore/Modules/mediasession/MediaSessionManager.cpp:48
> > +    m_interruptionProvider->beginListeningForInterruptions();
> 
> Shouldn't this and stopListeningForInterruptions be pure virtual?

Yeah. That wasn't possible before since we were calling these in MediaSessionInterruptionProvider's constructor/destructor, but now that that responsibility has been demoted to the caller, I'll make the switch.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20150819/6ee8564d/attachment.html>


More information about the webkit-unassigned mailing list