<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - Media Session: don't begin listening for interruptions when an interruption provider is created"
href="https://bugs.webkit.org/show_bug.cgi?id=148109#c4">Comment # 4</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - Media Session: don't begin listening for interruptions when an interruption provider is created"
href="https://bugs.webkit.org/show_bug.cgi?id=148109">bug 148109</a>
from <span class="vcard"><a class="email" href="mailto:mrajca@apple.com" title="Matt Rajca <mrajca@apple.com>"> <span class="fn">Matt Rajca</span></a>
</span></b>
<pre>(In reply to <a href="show_bug.cgi?id=148109#c3">comment #3</a>)
<span class="quote">> Comment on <span class=""><a href="attachment.cgi?id=259212&action=diff" name="attach_259212" title="Patch">attachment 259212</a> <a href="attachment.cgi?id=259212&action=edit" title="Patch">[details]</a></span>
> Patch
>
> View in context:
> <a href="https://bugs.webkit.org/attachment.cgi?id=259212&action=review">https://bugs.webkit.org/attachment.cgi?id=259212&action=review</a>
>
> > Source/WebCore/Modules/mediasession/MediaSessionManager.cpp:48
> > + m_interruptionProvider->beginListeningForInterruptions();
>
> Shouldn't this and stopListeningForInterruptions be pure virtual?</span >
Yeah. That wasn't possible before since we were calling these in MediaSessionInterruptionProvider's constructor/destructor, but now that that responsibility has been demoted to the caller, I'll make the switch.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>