[Webkit-unassigned] [Bug 148035] [ES6] Add TypedArray.prototype functionality.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=148035

--- Comment #3 from Keith Miller <keith_miller at apple.com> ---
Comment on attachment 259030
  --> https://bugs.webkit.org/attachment.cgi?id=259030
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=259030&action=review

>> Source/JavaScriptCore/builtins/TypedArray.prototype.js:30
>> +    var length = @typedArrayLength(this);
> 
> I recently unified our style for the builtins to be:
> 
> function functionName(arguments)
> {
>     "use strict";
> 
>     rest of function goes here
> }
> 
> It would be great if we could keep it consistent.

Fixed.

>> Source/JavaScriptCore/builtins/TypedArray.prototype.js:98
>> +            return true;
> 
> This for loop should have braces.

Fixed.

>> Source/JavaScriptCore/runtime/JSGenericTypedArrayViewInlines.h:343
>> +    // This is matching FireFox behavior. In particular, it rejects all attempts to
> 
> This seems unrelated and I don't think it is correct.  Firefox is spelled as one word.

Whoops, I was trying to figure out why that line was appearing in my diff but I couldn't figure it out... That would explain it.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20150814/ff5b385a/attachment.html>