<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - [ES6] Add TypedArray.prototype functionality."
href="https://bugs.webkit.org/show_bug.cgi?id=148035#c3">Comment # 3</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - [ES6] Add TypedArray.prototype functionality."
href="https://bugs.webkit.org/show_bug.cgi?id=148035">bug 148035</a>
from <span class="vcard"><a class="email" href="mailto:keith_miller@apple.com" title="Keith Miller <keith_miller@apple.com>"> <span class="fn">Keith Miller</span></a>
</span></b>
<pre>Comment on <span class=""><a href="attachment.cgi?id=259030&action=diff" name="attach_259030" title="Patch">attachment 259030</a> <a href="attachment.cgi?id=259030&action=edit" title="Patch">[details]</a></span>
Patch
View in context: <a href="https://bugs.webkit.org/attachment.cgi?id=259030&action=review">https://bugs.webkit.org/attachment.cgi?id=259030&action=review</a>
<span class="quote">>> Source/JavaScriptCore/builtins/TypedArray.prototype.js:30
>> + var length = @typedArrayLength(this);
>
> I recently unified our style for the builtins to be:
>
> function functionName(arguments)
> {
> "use strict";
>
> rest of function goes here
> }
>
> It would be great if we could keep it consistent.</span >
Fixed.
<span class="quote">>> Source/JavaScriptCore/builtins/TypedArray.prototype.js:98
>> + return true;
>
> This for loop should have braces.</span >
Fixed.
<span class="quote">>> Source/JavaScriptCore/runtime/JSGenericTypedArrayViewInlines.h:343
>> + // This is matching FireFox behavior. In particular, it rejects all attempts to
>
> This seems unrelated and I don't think it is correct. Firefox is spelled as one word.</span >
Whoops, I was trying to figure out why that line was appearing in my diff but I couldn't figure it out... That would explain it.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>