[Webkit-unassigned] [Bug 144956] [ES6] Implement ES6 arrow function syntax. Arrow function specific features. Lexical bind of this

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=144956

Filip Pizlo <fpizlo at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #258823|review?, commit-queue?      |review+, commit-queue-
              Flags|                            |

--- Comment #122 from Filip Pizlo <fpizlo at apple.com> ---
Comment on attachment 258823
  --> https://bugs.webkit.org/attachment.cgi?id=258823
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=258823&action=review

I'll cq+ if you make the two suggested changes.

> Source/JavaScriptCore/dfg/DFGMayExit.cpp:111
> +    case LoadArrowFunctionThis:

This sort of can exit.  It speculates that its child is a cell.

> Source/JavaScriptCore/ftl/FTLLowerDFGToLLVM.cpp:3115
> +        LBasicBlock slowPath = isArrowFunction
> +            ? FTL_NEW_BLOCK(m_out, ("NewArrowFunction slow path"))
> +            : FTL_NEW_BLOCK(m_out, ("NewFunction slow path"));

Just call it NewFunction.  No need for these branches just to get a different basic block name.

> Source/JavaScriptCore/ftl/FTLLowerDFGToLLVM.cpp:3119
> -        LBasicBlock slowPath = FTL_NEW_BLOCK(m_out, ("NewFunction slow path"));
> -        LBasicBlock continuation = FTL_NEW_BLOCK(m_out, ("NewFunction continuation"));
> +        LBasicBlock continuation = isArrowFunction
> +            ? FTL_NEW_BLOCK(m_out, ("NewArrowFunction continuation"))
> +            : FTL_NEW_BLOCK(m_out, ("NewFunction continuation"));

Ditto.

> Source/JavaScriptCore/runtime/JSArrowFunction.h:92
> +friend class LLIntOffsetsExtractor;

Indent this line.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20150813/94e81021/attachment.html>