<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body><span class="vcard"><a class="email" href="mailto:fpizlo@apple.com" title="Filip Pizlo <fpizlo@apple.com>"> <span class="fn">Filip Pizlo</span></a>
</span> changed
<a class="bz_bug_link
bz_status_NEW "
title="NEW - [ES6] Implement ES6 arrow function syntax. Arrow function specific features. Lexical bind of this"
href="https://bugs.webkit.org/show_bug.cgi?id=144956">bug 144956</a>
<br>
<table border="1" cellspacing="0" cellpadding="8">
<tr>
<th>What</th>
<th>Removed</th>
<th>Added</th>
</tr>
<tr>
<td style="text-align:right;">Attachment #258823 Flags</td>
<td>review?, commit-queue?
</td>
<td>review+, commit-queue-
</td>
</tr></table>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - [ES6] Implement ES6 arrow function syntax. Arrow function specific features. Lexical bind of this"
href="https://bugs.webkit.org/show_bug.cgi?id=144956#c122">Comment # 122</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - [ES6] Implement ES6 arrow function syntax. Arrow function specific features. Lexical bind of this"
href="https://bugs.webkit.org/show_bug.cgi?id=144956">bug 144956</a>
from <span class="vcard"><a class="email" href="mailto:fpizlo@apple.com" title="Filip Pizlo <fpizlo@apple.com>"> <span class="fn">Filip Pizlo</span></a>
</span></b>
<pre>Comment on <span class=""><a href="attachment.cgi?id=258823&action=diff" name="attach_258823" title="Patch">attachment 258823</a> <a href="attachment.cgi?id=258823&action=edit" title="Patch">[details]</a></span>
Patch
View in context: <a href="https://bugs.webkit.org/attachment.cgi?id=258823&action=review">https://bugs.webkit.org/attachment.cgi?id=258823&action=review</a>
I'll cq+ if you make the two suggested changes.
<span class="quote">> Source/JavaScriptCore/dfg/DFGMayExit.cpp:111
> + case LoadArrowFunctionThis:</span >
This sort of can exit. It speculates that its child is a cell.
<span class="quote">> Source/JavaScriptCore/ftl/FTLLowerDFGToLLVM.cpp:3115
> + LBasicBlock slowPath = isArrowFunction
> + ? FTL_NEW_BLOCK(m_out, ("NewArrowFunction slow path"))
> + : FTL_NEW_BLOCK(m_out, ("NewFunction slow path"));</span >
Just call it NewFunction. No need for these branches just to get a different basic block name.
<span class="quote">> Source/JavaScriptCore/ftl/FTLLowerDFGToLLVM.cpp:3119
> - LBasicBlock slowPath = FTL_NEW_BLOCK(m_out, ("NewFunction slow path"));
> - LBasicBlock continuation = FTL_NEW_BLOCK(m_out, ("NewFunction continuation"));
> + LBasicBlock continuation = isArrowFunction
> + ? FTL_NEW_BLOCK(m_out, ("NewArrowFunction continuation"))
> + : FTL_NEW_BLOCK(m_out, ("NewFunction continuation"));</span >
Ditto.
<span class="quote">> Source/JavaScriptCore/runtime/JSArrowFunction.h:92
> +friend class LLIntOffsetsExtractor;</span >
Indent this line.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>