[Webkit-unassigned] [Bug 147802] Media Session: notify the UI process when media controls are enabled/disabled

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=147802

--- Comment #13 from Matt Rajca <mrajca at apple.com> ---
(In reply to comment #12)
> Comment on attachment 258684 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=258684&action=review
> 
> > Source/WebCore/Modules/mediasession/MediaSession.cpp:74
> > -        m_controls = adoptRef(*new MediaRemoteControls(context));
> > +        m_controls = adoptRef(*new MediaRemoteControls(context, this));
> 
> Why doesn't this use MediaRemoteControls::create() (which would need an
> extra parameter)?

The bindings generator expects only one parameter (the ScriptExecutionContext) so I can't add another one. Since the only case where we need to store a backpointer to the media session is this one, I just create the object directly.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20150812/208de52b/attachment-0001.html>